(SDK-312) Add option --parallel to pdk test unit
#154
Conversation
lib/pdk/tests/unit.rb
Outdated
| # TODO: test selection | ||
| [File.join(PDK::Util.module_root, 'bin', 'rake'), 'spec'] | ||
| if opts.key?(:parallel) | ||
| [File.join(PDK::Util.module_root, 'bin', 'rake'), 'parallel'] |
There was a problem hiding this comment.
This will need to change once puppetlabs_spec_helper is updated. Added the updated parallel_spec task to the module's Rakefile as parallel to avoid name conflicts.
There was a problem hiding this comment.
As this is just deciding between two rake tasks, you can remove a bit of duplication here by changing the method content to something like this
rake_task = opts.key?(:parallel) ? 'parallel' : 'spec'
[File.join(PDK::Util.module_root, 'bin', 'rake'), rake_task]
austb
force-pushed
the
parallel_tests
branch
3 times, most recently
from
ff054ae
to
b1c9fe6
Compare
austb
changed the title
pdk test unit
austb
changed the title
pdk test unitpdk test unit
austb
force-pushed
the
parallel_tests
branch
2 times, most recently
from
044208b
to
11b9407
Compare
austb
force-pushed
the
parallel_tests
branch
3 times, most recently
from
37819ff
to
0e8d00f
Compare
spec/unit/pdk/test/unit_spec.rb
Outdated
| require 'pdk/tests/unit' | ||
|
|
||
| describe PDK::Test::Unit do | ||
| describe 'merging json results' do |
There was a problem hiding this comment.
Should change the description of this example group to the method being tested describe '.merge_json_results'
spec/unit/pdk/test/unit_spec.rb
Outdated
| end | ||
| end | ||
|
|
||
| describe '#cmd' do |
There was a problem hiding this comment.
This is a class method, so .cmd would be better.
spec/unit/pdk/test/unit_spec.rb
Outdated
| end | ||
| end | ||
|
|
||
| describe '#parse_output' do |
There was a problem hiding this comment.
This is a class method, so .parse_output would be better.
spec/unit/pdk/test/unit_spec.rb
Outdated
|
|
||
| # Allow any_instance stubbing of Commands | ||
| # rubocop:disable RSpec/AnyInstance | ||
| describe '#list' do |
There was a problem hiding this comment.
This is a class method, so .list would be better.
spec/unit/pdk/test/unit_spec.rb
Outdated
| end | ||
| end | ||
|
|
||
| describe '#invoke' do |
There was a problem hiding this comment.
This is a class method, so .invoke would be better.
Uses the puppetlabs_spec_helper Rake task 'parallel_spec' to run spec tests in parallel. This will run the Rake task in multiple Processes to avoid the limitation on Thread speed increases due to MRI Ruby's Global Interpreter Lock. This means that rspec initialization effort will be duplicated.
Waiting for a new version of puppetlabs_spec_helper for the updated rake task
Update:
I now believe it's waiting for a new version of puppet-module-gems
Update 2:
v0.1.0 of puppet-module-gems has been released